Skip to content

Remove AccessKit dynamic wrappers, add download script and build warning if libs are missing.#117313

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
bruvzg:no_dyn
Mar 11, 2026
Merged

Remove AccessKit dynamic wrappers, add download script and build warning if libs are missing.#117313
Repiteo merged 1 commit into
godotengine:masterfrom
bruvzg:no_dyn

Conversation

@bruvzg
Copy link
Copy Markdown
Member

@bruvzg bruvzg commented Mar 11, 2026

No description provided.

@bruvzg bruvzg added this to the 4.x milestone Mar 11, 2026
@bruvzg bruvzg requested a review from a team as a code owner March 11, 2026 07:32
akien-mga
akien-mga reviewed Mar 11, 2026
View reviewed changes
Comment thread platform/windows/detect.py Outdated
akien-mga
akien-mga reviewed Mar 11, 2026
View reviewed changes
Comment thread SConstruct Outdated
@akien-mga
Copy link
Copy Markdown
Member

akien-mga commented Mar 11, 2026

Looks great.

Could you adjust the GHA workflows to use the new script?

workflows/windows_builds.yml
13:    "accesskit_sdk_path=${{ github.workspace }}/accesskit-c-0.21.1/"
101:          repo: godotengine/godot-accesskit-c-static
103:          file: accesskit-c-0.21.1.zip
104:          target: accesskit-c-0.21.1/accesskit_c.zip
107:        run: unzip -o accesskit-c-0.21.1/accesskit_c.zip

workflows/macos_builds.yml
11:    "accesskit_sdk_path=${{ github.workspace }}/accesskit-c-0.21.1/"
56:          repo: godotengine/godot-accesskit-c-static
58:          file: accesskit-c-0.21.1.zip
59:          target: accesskit-c-0.21.1/accesskit_c.zip
62:        run: unzip -o accesskit-c-0.21.1/accesskit_c.zip

workflows/linux_builds.yml
16:    "accesskit_sdk_path=${{ github.workspace }}/accesskit-c-0.21.1/"
171:          repo: godotengine/godot-accesskit-c-static
173:          file: accesskit-c-0.21.1.zip
174:          target: accesskit-c-0.21.1/accesskit_c.zip
177:        run: unzip -o accesskit-c-0.21.1/accesskit_c.zip

And I assume this could be moved to the godot-deps action instead of being replicated in all 3 desktop workflows.

akien-mga
akien-mga approved these changes Mar 11, 2026
View reviewed changes
Comment thread .github/workflows/linux_builds.yml Outdated
Comment thread .github/workflows/macos_builds.yml Outdated
Comment thread .github/workflows/windows_builds.yml Outdated
@akien-mga akien-mga modified the milestones: 4.x, 4.7 Mar 11, 2026
@Repiteo Repiteo merged commit 075d6f2 into godotengine:master Mar 11, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Mar 11, 2026

Thanks!

@bruvzg bruvzg mentioned this pull request Mar 15, 2026
Merged
@bruvzg bruvzg mentioned this pull request May 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

enhancement platform:linuxbsd platform:macos platform:windows topic:buildsystem usability

Projects

None yet

Milestone

4.7

Development

Successfully merging this pull request may close these issues.

3 participants

@bruvzg @akien-mga @Repiteo